Flaky tests detected in dad7083.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12589925664
📝 Reported issues:

• [Flaky Test] Navigates the items list via UP/DOWN arrow keys #64334 in /test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js

So far, I have not implemented the actual proxying yet. I would like to get a sense of whether this minor expansion of the Interactivity API infrastructure makes sense before continuing.

I don't know the codebase, but you are on track as much as I understand the changes and their implications. Thank you for continuing to work on it. I also wanted to share that it might not be easy to get more feedback in the next 2-3 weeks as many folks, myself included, take longer holiday breaks 🎉

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: gziolo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

I have implemented the event proxying logic. For now, I'm warning about accessing the following without withSyncEvent():

• event.currentTarget
• event.preventDefault()
• event.stopImmediatePropagation()
• event.stopPropagation()

As discussed on the issue, there may be more properties and methods to warn about, but we could always expand later. I think these 4 are a good starting point and should cover what's most common.

Keep in mind that for now there is only a warning, but no functional behavior change. We can only yield before all callbacks that aren't using withSyncEvent() after at least one release cycle (which is why the warning message mentions WordPress 6.9, as this enhancement ideally launches as part of WordPress 6.8).

Review much appreciated!

Any chance I can get 1-2 reviews for the PR this week? That would be super helpful so we could ideally land this in Gutenberg soon. Thank you! 🙌

Some updates:

• In 21e51be I fixed support for generator functions so that they're still recognized as such even when wrapped.
• In a582f01 I updated the Interactivity API docs accordingly to include withSyncEvent().
• In 5d68fcb I updated all relevant built-in actions to use withSyncEvent() as necessary.
  • This of course adds a bunch more files changed to the PR, so I'd recommend reviewing the commits individually at this point, as it makes things easier.
  • If you prefer that we do this separately, we can also temporarily revert this commit.

Size Change: +702 B (+0.04%)

Total Size: 1.84 MB

_{compressed-size-action}